FontRegister: Let BaseRenderBuilder close the resource stream#39
Merged
Conversation
Previously the font register was attempting to handle the lifecycle of the resource stream for the font, which caused it to close it prematurely, causing the renderer to always fall back to the default font. The documentation of BaseRenderBuilder#useFont states 'The InputStream returned by the supplier will be closed by the caller' so this behavior was pointless anyway. With this commit the FontRegister now just passes along a supplier for opening an input stream to the resource and lets the BaseRenderBuilder handle the rest.
nihas101
force-pushed
the
fix/font-loading
branch
from
July 18, 2026 09:52
21bd12e to
511dc82
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the font register was attempting to handle the lifecycle of the resource stream for the font, which caused it to close it prematurely, causing the renderer to always fall back to the default font. The documentation of BaseRenderBuilder#useFont states
so this behavior was pointless anyway. With this commit the FontRegister now just passes along a supplier for opening an input stream to the resource and lets the BaseRenderBuilder handle the rest.